feat: annotated argpare adding support for frozenset#1691
Merged
Conversation
frozenset[T] joins list/set/tuple as a supported collection annotation: it registers the same single-arg collection resolver, coerces the parsed values into a frozenset, and rejects nested collections like the others. Adds a do_tags example and parametrizes the container runtime-cast test (which now also covers frozenset).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1691 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 23 23
Lines 5678 5678
=======================================
Hits 5654 5654
Misses 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
tleonhardt
previously approved these changes
Jun 11, 2026
Address review feedback on #1691: frozenset[T] was functionally supported but the error messages and docstrings enumerating the supported collection types still only mentioned list/set/tuple. Update those strings so exceptions and docs accurately list frozenset, and add a CHANGELOG entry for the new collection type.
tleonhardt
approved these changes
Jun 11, 2026
tleonhardt
left a comment
tleonhardt
left a comment
Member
There was a problem hiding this comment.
Consider if the user-facing documentation under docs/ should be updated for this.
I'll merge it in as-is. If you think the documentation should be updated, that can come later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1685